Skip to content

feat: add interchangeable transaction signers - #53

Open
Gozirimdev wants to merge 2 commits into
Vero-protocol:mainfrom
Gozirimdev:feat/issue--wallet-signers
Open

feat: add interchangeable transaction signers#53
Gozirimdev wants to merge 2 commits into
Vero-protocol:mainfrom
Gozirimdev:feat/issue--wallet-signers

Conversation

@Gozirimdev

Copy link
Copy Markdown

Close #46

Related issue

GrantFox requires every PR to link the issue it resolves. Replace #123 with the actual issue number.

Closes #123

Summary

Changes made

Testing performed

Checklist

  • npm test passes
  • npm run typecheck reports no errors
  • npm run lint reports no errors
  • PR description links the resolved issue with Closes #<issue-number>

@Gozirimdev
Gozirimdev force-pushed the feat/issue--wallet-signers branch from 6efe83d to 74e2f12 Compare August 22, 2026 20:35
@N-thnI

N-thnI commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

CI was green here, but merging #54 and #52 just now put this into conflict. Could you rebase onto main? Should be straightforward — the conflicts are in src/index.ts exports rather than in your signer code.

Three conflicts resolved:

- src/index.ts: union. Keeps every export already on main (with the .js
  extensions the ESM build from Vero-protocol#60 requires, plus Vero-protocol#57's backoff export) and
  adds the signers module using the same convention.
- src/errors/index.ts: union. Keeps main's fully documented TransactionFailed
  entry from Vero-protocol#59 and brings this branch's NetworkMismatch member across,
  rewritten in the same @cause/@retryable/@handling house style rather than the
  one-line comment it arrived with.
- package-lock.json: regenerated from the merged package.json rather than
  hand-merged.

Verified after resolution: typecheck clean, 168 tests pass, lint clean
(2 pre-existing warnings), docs generate.
@N-thnI

N-thnI commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

please ensure all checks pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement wallet signers: Freighter, Rabet, keypair, and a shared interface

2 participants